Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Cleanup previews only if they actually exist #323

Merged
merged 1 commit into from
May 8, 2024
Merged

[CI] Cleanup previews only if they actually exist #323

merged 1 commit into from
May 8, 2024

Conversation

giordano
Copy link
Member

@giordano giordano commented May 8, 2024

Fix #322.

@giordano giordano requested a review from tkoskela May 8, 2024 10:50
tkoskela
tkoskela approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@giordano giordano merged commit 7bbe54a into main May 8, 2024
@giordano giordano deleted the mg/cleanup-only-if-exists branch May 8, 2024 12:08
@giordano
Copy link
Member Author

giordano commented May 8, 2024

As an evidence that this worked: the job triggered by the merged of this PR didn't do anything and exited successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoskela tkoskela tkoskela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup action fails
2 participants
@giordano @tkoskela