Set PostgreSQL password in CircleCI build #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reupen
force-pushed
the
bugfix/circleci-postgres-pw
branch
5 times, most recently
from
3f886a0
to
fabb830
Compare
reupen
requested review from
elcct,
web-bert,
alixedi,
currycoder and
sekharpanja
elcct
approved these changes
Feb 17, 2020
currycoder
reviewed
Feb 17, 2020
alixedi
requested review from
elcct and
alixedi
and removed request for
sekharpanja,
web-bert and
alixedi
alixedi
approved these changes
Feb 17, 2020
currycoder
approved these changes
Feb 17, 2020
elcct
approved these changes
Feb 17, 2020
elcct
approved these changes
Feb 17, 2020
The `postgres` Docker image now requires a password to be set. This change sets a password in the CircleCI build to meet that requirement. See docker-library/postgres#681 for more information.
reupen
force-pushed
the
bugfix/circleci-postgres-pw
branch
from
fabb830
to
f35b407
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2596 +/- ##
========================================
Coverage 97.83% 97.83%
========================================
Files 345 345
Lines 10663 10663
Branches 1040 1040
========================================
Hits 10432 10432
Misses 156 156
Partials 75 75Continue to review full report at Codecov.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
postgresDocker image now requires a password to be set. This change sets a password in the CircleCI build to meet that requirement.See docker-library/postgres#681 for more information.
Checklist
fixtures/test_data.yaml) been updated?