Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated log_action with log_actions #566

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Replace deprecated log_action with log_actions #566

merged 4 commits into from
Dec 6, 2024

Conversation

CaitBarnard
Copy link
Contributor

@CaitBarnard CaitBarnard commented Dec 6, 2024 •
edited
Loading

Replace usages of log_action() with log_actions()

log_actions takes similar parameters but now takes a queryset which is the model object.
Updated one log_action to be a create() as it takes no object

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

@CaitBarnard CaitBarnard marked this pull request as ready for review December 6, 2024 12:31
@CaitBarnard CaitBarnard requested a review from a team as a code owner December 6, 2024 12:31
@CaitBarnard CaitBarnard merged commit d96c820 into main Dec 6, 2024
4 checks passed
@CaitBarnard CaitBarnard deleted the FF-123/log_action_deprecation branch December 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamDudley SamDudley SamDudley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaitBarnard @SamDudley