Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT-150 Add django debug toolbar #589

Merged
merged 8 commits into from
Jan 3, 2025
Merged

FFT-150 Add django debug toolbar #589

merged 8 commits into from
Jan 3, 2025

Conversation

DenisDDBT
Copy link
Contributor

  • JIRA ticket referenced in title
  • Title is clear and concise
  • Description gives any relevant detail
  • Tests are up to date
  • Documentation is up to date

@DenisDDBT DenisDDBT marked this pull request as ready for review January 3, 2025 11:05
@DenisDDBT DenisDDBT requested a review from a team as a code owner January 3, 2025 11:05
CamLamb
CamLamb reviewed Jan 3, 2025
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@DenisDDBT DenisDDBT force-pushed the FFT-150/dev-experience-improvements branch from 2cc8898 to 2c6a234 Compare January 3, 2025 12:08
@DenisDDBT DenisDDBT force-pushed the FFT-150/dev-experience-improvements branch from 2c6a234 to e643f64 Compare January 3, 2025 12:12
@DenisDDBT DenisDDBT changed the title [FFT-150] Adding django debug toolbar and pg-admin to the project [FFT-150] Adding django debug toolbar to the project Jan 3, 2025
@DenisDDBT
Copy link
Contributor Author

DenisDDBT commented Jan 3, 2025 •
edited
Loading

@CamLamb @SamDudley fixed change request.

SamDudley
SamDudley reviewed Jan 3, 2025
View reviewed changes
config/settings/local.py Outdated Show resolved Hide resolved
config/settings/local.py Outdated Show resolved Hide resolved
@DenisDDBT DenisDDBT force-pushed the FFT-150/dev-experience-improvements branch from 439872d to bcbc5a5 Compare January 3, 2025 16:35
SamDudley
SamDudley approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@SamDudley SamDudley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamDudley SamDudley changed the title [FFT-150] Adding django debug toolbar to the project FFT-150 Add django debug toolbar Jan 3, 2025
@DenisDDBT DenisDDBT merged commit 024e971 into main Jan 3, 2025
4 checks passed
@DenisDDBT DenisDDBT deleted the FFT-150/dev-experience-improvements branch January 3, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamLamb CamLamb CamLamb left review comments

@SamDudley SamDudley SamDudley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenisDDBT @CamLamb @SamDudley