LTD-5817-add-application-history #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currycoder
approved these changes
Jan 29, 2025
| url = reverse("applications:application", kwargs={"pk": application["id"]}) | ||
| response = authorized_client.get(url) | ||
| soup = BeautifulSoup(response.content, "html.parser") | ||
|
|
||
| products_table = soup.find_all("table", attrs={"class": "govuk-table"})[0] |
There was a problem hiding this comment.
Rather than relying on finding the second table, can we make this lookup more bulletproof with a unique CSS id or something?
There was a problem hiding this comment.
added id and to search by id
depsiatwal
force-pushed
the
LTD-5817-add-application-history
branch
from
133570b to
47c2de7
Compare
depsiatwal
force-pushed
the
LTD-5817-add-application-history
branch
from
47c2de7 to
6253ff6
Compare
depsiatwal
force-pushed
the
LTD-5817-add-application-history
branch
from
5dcbe43 to
4d00a35
Compare
currycoder
reviewed
Jan 31, 2025
Comment on lines
14
to
36
| {% if prev_application.status.status != "draft" %} | ||
| <td class="govuk-table__cell"> | ||
| {% if prev_application.id == application.id %} | ||
| {{ prev_application.reference_code }} | ||
| {% else %} | ||
| <a href="{% url 'applications:application' prev_application.id %}">{{ prev_application.reference_code }}</a> | ||
| {% endif %} | ||
| </td> | ||
| <td class="govuk-table__cell">{{ prev_application.submitted_at|str_date }}</td> | ||
| <td class="govuk-table__cell" id="label-application-status-{{ forloop.counter }}"> <div class="govuk-tag govuk-tag--grey govuk-!-margin-0">{{ prev_application.status.status_display }}</div></td> | ||
| <td class="govuk-table__cell"> | ||
| {% if prev_application.ecju_query_count > 0 %} | ||
| <a href="{% url 'applications:application' prev_application.id 'ecju-queries' %}">{{ prev_application.ecju_query_count }}</a> | ||
| {% endif %} | ||
| </td> | ||
| {% else %} | ||
| <td class="govuk-table__cell"> | ||
| <a href="{% url 'applications:task_list' prev_application.id %}" >{{ prev_application.status.status_display|capfirst }}</a> | ||
| </td> | ||
| <td class="govuk-table__cell"/> | ||
| <td class="govuk-table__cell" id="label-application-status-{{ forloop.counter }}"> <div class="govuk-tag govuk-tag--grey govuk-!-margin-0">{{ prev_application.status.status_display }}</div></td> | ||
| <td class="govuk-table__cell"/> | ||
| {% endif %} |
There was a problem hiding this comment.
Maybe flipping round the if statement will make this slightly easier to understand e.g.
{% if prev_application.status.status == "draft" %}
// draft table
{% else %}
// non-draft table
{% endif %}
currycoder
approved these changes
Jan 31, 2025
depsiatwal
force-pushed
the
LTD-5817-add-application-history
branch
from
83507f3 to
0e5981c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uktrade.atlassian.net/browse/LTD-5817
Add a new view on the exporter application details.
This utilises a new endpoint which extracts the history
uktrade/lite-api#2388