feat: only GRANT when ingesting into a new table #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying the SELECT permissions on each batch is semantically fine, but - Unnecessary at best - And at worst, can cause hanging and "tuple concurrently updated" errors when other clients try to do GRANT SELECT on the tables in question This change makes it so the copy of SELECT privileges only happens when we ingest the first batch into a new table, and never otherwise. There is an existing test test_migrate_add_column_not_at_end_permissions_preserved that test permissions are preserved.
michalc
force-pushed
the
feat/fewer-permission-copies
branch
from
52ace18 to
32804e6
Compare
peter-woodcock
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the SELECT permissions on each batch is semantically fine, but
This change makes it so the copy of SELECT privileges only happens when we ingest the first batch into a new table, and never otherwise.
There is an existing test test_migrate_add_column_not_at_end_permissions_preserved that test permissions are preserved.