perf: GRANT all SELECT privileges in a single query #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
changed the title
michalc
force-pushed
the
perf/combine-grants
branch
2 times, most recently
from
c98032b to
8dbf1a0
Compare
This reduces the number of queries run when copying existing SELECT privileges, which happens at the end of the first batch in the cases when the ingest is not directly into the live table. The existing test that privileges are preserved is extended to make sure the `','.join(...` behaviour is correct
michalc
force-pushed
the
perf/combine-grants
branch
from
8dbf1a0 to
4d3a2f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of queries run when copying existing SELECT privileges, which happens at the end of the first batch in the cases when the ingest is not directly into the live table.
The existing test that privileges are preserved is extended to make sure the
','.join(...behaviour is correct