This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
MODUL 716 - style scopé pour formulaire #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* utilisation de classe formulaire au lieu des classe utilitaire
chuckmah
approved these changes
Jan 30, 2019
chuckmah
pushed a commit
that referenced
this pull request
Feb 1, 2019
* * ajouter une fonctionnalité de validation au niveau du formulaire * * typo * * renaming * small refactor * * removed unused method * * small fixes * * change form state to be the internal state of the form * added form validation class to represent the return of each validator callback of the form * updated tests and sandbox * * missing doc * * allow to display error message only when form field is touched * * fix errorMessage algo to return errorMessage if messageAfterTouched = false * added use case to sandbox * * renaming * tests * * moved touch closer to validate * * typo * * removed unsused line * * renaming * * renaming * * use form plugin * * use to more strict toBe method * reformat condition and use of variable to hold the value * MODUL-707 - * use non-null assertion operator * MODUL-710 - * access formfield by name * new constructor for the form with form field group * * renaming * MODUL-710 - * renaming and typing * * merge fix * merge fix * * formating * ENA2-4264 - Add multiple validators * ENA2-4264 - Allow toast to contain html * ENA2-4264 - Fix plugin * * missing doc * ENA2-4264 - Move params from constructor to validating class and allow single function validating class * Rebase and fixes * * touch field to mark as touched + validate them * bring back focus if only one field has error * display summary error if it have errors & only one field have an error * MODUL 716 - style scopé pour formulaire (#696) * MODUL-716 - * ajout form.scss * utilisation de classe formulaire au lieu des classe utilitaire * MODUL-716 - * updated snapshot * * use of v-html for validation message * rename prop hasRequiredFields by requiredMarker * MODUL-719 - * form field directive * MODUL-719 - * remove unused setter * remove unused setter * MODUL-719 - * removed unused delclaration * MAJ du style du champ requis * Ajouter une transition accordeon pour l'affichage du message d'erreur * Maj champ requis * MODUL-719 - * removed directive pluggin in favor of vue.directive * added touch test * small fixes * MODUL-719 - * updated tests * updated algo when form field is use on input * MODUL-719 - * add comment for hack-ish code * MODUL-719 - * refactor * * removed weird import * Delete form-field.ts * * added key * renaming * use push in favor of concat * MODUL-719 - * await on forceUpdate * MODUL-719 - * more generic algo * * renamed css class * updated snapshots * throw error if field not found in form * * look like the weird import was necessary * * please travis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ulaval/modul-componentsPR Checklist
Utilisation de style scopé pour le formulaire
https://jira.dti.ulaval.ca/browse/MODUL-716