Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test cases for companies #6

Open
wants to merge 1 commit into
base: release/14.3
Choose a base branch
from
Open

test cases for companies #6

wants to merge 1 commit into from

Conversation

ulferts
Copy link
Owner

@ulferts ulferts commented Feb 9, 2021 •
edited
Loading

Test case for applicants.

The objective is to be knowledgeable about the requirements formulated as spec/requests/api/v3/companies_resource_spec.rb and then later be able to converse about it.

@ulferts ulferts force-pushed the application/backend-api branch 2 times, most recently from 1b0539b to 8a99c6e Compare May 7, 2021 10:39
wielinde
wielinde reviewed May 7, 2021
View reviewed changes
Copy link

@wielinde wielinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jens, of cause I didn't do the challenge. So I can't really tell if it is feasible. However, here two small wording improvements

spec/requests/api/v3/companies_resource_spec.rb Outdated Show resolved Hide resolved
spec/requests/api/v3/companies_resource_spec.rb Show resolved Hide resolved
@ulferts ulferts force-pushed the application/backend-api branch 2 times, most recently from 337dd30 to f12c5d3 Compare June 11, 2021 06:33
@ulferts ulferts force-pushed the application/backend-api branch 2 times, most recently from 2e942da to 7e4e98b Compare August 25, 2021 13:14
@ulferts ulferts changed the base branch from dev to release/12.0 December 8, 2021 14:26
@ulferts ulferts changed the base branch from release/12.0 to release/12.1 May 13, 2022 14:31
@ulferts ulferts changed the base branch from release/12.1 to release/12.3 November 21, 2022 07:21
@ulferts ulferts force-pushed the application/backend-api branch 2 times, most recently from 167a143 to 08a8177 Compare November 21, 2022 07:43
@ulferts ulferts changed the base branch from release/12.3 to release/12.5 May 22, 2023 08:41
@ulferts ulferts changed the base branch from release/12.5 to release/13.0 August 30, 2023 07:52
@ulferts ulferts changed the base branch from release/13.0 to release/13.2 January 26, 2024 08:17
ulferts pushed a commit that referenced this pull request Mar 22, 2024
@btey
Merge pull request #6 from oliverguenther/fix/overrides
2cef1b3 
Remove requiring changes to the OpenProject core
@ulferts ulferts force-pushed the application/backend-api branch 2 times, most recently from d3760c0 to 9478d8a Compare March 22, 2024 08:37
@ulferts ulferts changed the base branch from release/13.2 to release/13.4 March 22, 2024 08:41
@ulferts ulferts changed the base branch from release/13.4 to release/14.3 July 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wielinde wielinde wielinde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulferts @wielinde