Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/Stokhos
Motivation
HIP
is not tested as thoroughly as other execution spaces. This is a proposal that should ease tester life when he/she wants to add additional execution spaces for a test. This should reduce the amount of copy/paste.This PR introduces a CMake function that will loop over the list of given spaces, and for each space check that the required variable is defined. If it is defined, the test is added, otherwise it is not.
To do if @etphipp approves the approach:
UnitTest/CMakeLists.txt
has been simplified everywhere withSTOKHOS_ADD_EXECUTABLE_AND_TEST
packages/stokhos/test/UnitTest/Stokhos_TpetraCrsMatrixMPVectorUnitTest_*.cpp
Stokhos_<test-name>_HIP.cpp
if still required