Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stokhos simplify testing #3

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

romintomasetti
Copy link
Collaborator

@romintomasetti romintomasetti commented Jul 7, 2022

@trilinos/Stokhos

Motivation

HIP is not tested as thoroughly as other execution spaces. This is a proposal that should ease tester life when he/she wants to add additional execution spaces for a test. This should reduce the amount of copy/paste.

This PR introduces a CMake function that will loop over the list of given spaces, and for each space check that the required variable is defined. If it is defined, the test is added, otherwise it is not.

To do if @etphipp approves the approach:

  • Check that the UnitTest/CMakeLists.txt has been simplified everywhere with STOKHOS_ADD_EXECUTABLE_AND_TEST
  • Check if there are other opportunities to unify entrypoints into a single entrypoint, like I did for packages/stokhos/test/UnitTest/Stokhos_TpetraCrsMatrixMPVectorUnitTest_*.cpp
  • Add missing Stokhos_<test-name>_HIP.cpp if still required

@romintomasetti romintomasetti force-pushed the stokhos-simplify-testing branch 2 times, most recently from 43d3bc5 to 7f451ed Compare July 7, 2022 14:17
@romintomasetti
Copy link
Collaborator Author

@etphipp Could you please (in)validate this new approach ? This would help us increase the coverage of the testing for HIP 😃

@romintomasetti romintomasetti force-pushed the stokhos-simplify-testing branch from 7f451ed to a593daf Compare July 7, 2022 14:29
Copy link
Collaborator

@etphipp etphipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

maartenarnst pushed a commit that referenced this pull request Aug 22, 2023
maartenarnst pushed a commit that referenced this pull request Aug 7, 2024
MueLu: Modify deepcopy regression test logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants