-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Add options. Revise directory tree. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenarnst
commented
Jun 12, 2024
9fa42c0
to
ca662e2
Compare
d8cc3aa
to
f578714
Compare
maartenarnst
commented
Jun 14, 2024
maartenarnst
commented
Jun 14, 2024
maartenarnst
commented
Jun 14, 2024
dd105a9
to
bf660eb
Compare
ed4c111
to
0e75055
Compare
7f2139b
to
05a069b
Compare
romintomasetti
approved these changes
Jun 17, 2024
Move dockerfile to dedicated docker directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts to fill our
Kokkos-utils
library with a header file, a test, and doc.Description
tests
anddoc
Kokkos
andGTest
if the needed targets are not yet definedadd_one_test
helper functiontests.dox
with a Doxygen groupunittests
to collect a list of unit testsThe second and third changes are needed to allow
kokkos-utils
builds as part of another code. This other code may provide the targets for the needed dependencies. And we don't want to interfere with how it sets the CXX standard.Related to
Extends: