Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: VAC-1209 Add missing env var for npm version #54

Merged
merged 1 commit into from
Nov 30, 2023
Merged

patch: VAC-1209 Add missing env var for npm version #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/cron_deploy-from-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ env:
LINT_COMMAND: ${{ inputs.lint_command }}
NPM_INSTALL_COMMAND: ${{ inputs.npm_install_command }}
NODE_VERSION: ${{ inputs.node_version }}
NPM_VERSION: ${{ inputs.npm_version }}


jobs:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cron_merged-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ env:
TEST_COMMAND: ${{ inputs.test_command }}
BUILD_COMMAND: ${{ inputs.build_command }}
LINT_COMMAND: ${{ inputs.lint_command }}
NPM_VERSION: ${{ inputs.npm_version }}

jobs:
bump-release:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy-from-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ env:
APP_NAMES: ${{ inputs.app_names }}
NPM_INSTALL_COMMAND: ${{ inputs.npm_install_command }}
NODE_VERSION: ${{ inputs.node_version }}
NPM_VERSION: ${{ inputs.npm_version }}


jobs:
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/exceptional_stage_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ env:
APP_NAMES: ${{ inputs.app_names }}
NPM_INSTALL_COMMAND: ${{ inputs.npm_install_command }}
NODE_VERSION: ${{ inputs.node_version }}
NPM_VERSION: ${{ inputs.npm_version }}


jobs:
Expand All @@ -98,16 +99,16 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}

- name: npm install
if: ${{ env.NPM_VERSION }}
run: npm i -g npm@${{ env.NPM_VERSION }} --registry=https://registry.npmjs.org

- id: "image_name"
name: "Get repo name and update IMAGE_NAME"
run: |-
IMAGE_NAME=$IMAGE_REPO"/"${{ github.event.repository.name }}
echo "image_name=$IMAGE_NAME" >> $GITHUB_OUTPUT

- name: npm install
if: ${{ env.NPM_VERSION }}
run: npm i -g npm@${{ env.NPM_VERSION }} --registry=https://registry.npmjs.org

- id: "app_names"
name: "Get app_names if necessary"
run: |-
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/merged-lib-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ env:
LINT_COMMAND: ${{ inputs.lint_command }}
PUBLISH_COMMAND: ${{ inputs.publish_command }}
CI: true
NPM_VERSION: ${{ inputs.npm_version }}

jobs:
bump-release:
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/merged-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ env:
TEST_COMMAND: ${{ inputs.test_command }}
BUILD_COMMAND: ${{ inputs.build_command }}
LINT_COMMAND: ${{ inputs.lint_command }}
NPM_VERSION: ${{ inputs.npm_version }}

jobs:
bump-release:
Expand Down Expand Up @@ -123,10 +124,6 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}

- name: npm install
if: ${{ env.NPM_VERSION }}
run: npm i -g npm@${{ env.NPM_VERSION }} --registry=https://registry.npmjs.org

- name: npm install
if: ${{ env.NPM_VERSION }}
run: npm i -g npm@${{ env.NPM_VERSION }} --registry=https://registry.npmjs.org
Expand Down Expand Up @@ -176,6 +173,10 @@ jobs:
with:
node-version: ${{ env.NODE_VERSION }}

- name: npm install
if: ${{ env.NPM_VERSION }}
run: npm i -g npm@${{ env.NPM_VERSION }} --registry=https://registry.npmjs.org

- id: "image_name"
name: "Get repo name and update IMAGE_NAME"
run: |-
Expand Down