Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache package count values instead of the generated text #2217

Closed
wants to merge 1 commit into from

Conversation

geoffliu
Copy link
Contributor

An issue I noticed with the new caching scheme is that if the full text is cached, then changes in format config aren't reflected until the cache expires, which could be confusing to the user. We cache the package count numbers instead, and render the text according to config every time.

@lasers
Copy link
Contributor

lasers commented Nov 2, 2023

See the alternative solution. It should still do what you want.

@geoffliu geoffliu closed this Dec 25, 2023
@geoffliu geoffliu deleted the value-caching branch December 25, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants