fix tempfile and new output in conky module #2273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes:
Fixes for 2 problems:
In my case, with conky
1.21.7-pre-
(default version with latest Fedora) outputsconky: 'i3' x11 session running 'i3' desktop
NamedTemporaryFile
needsdelete_on_close=False
(which I thought was implied bydelete=False
, but apparently that is not the case)A small refactor:
invalid_conky_errors
toignored_conky_outputs
as they're actually just expected outputs that we don't care about (and not really runtime problems requiring a warning/exit/exception)