Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml #959

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Update links.yml #959

merged 3 commits into from
Dec 25, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 25, 2024

๐Ÿ› ๏ธ PR Summary

Made with โค๏ธ by Ultralytics Actions

๐ŸŒŸ Summary

Improved installation of the link-checking tool Lychee in the GitHub workflow for better efficiency. ๐Ÿš€

๐Ÿ“Š Key Changes

  • Updated the script to directly extract and move the Lychee tool to the correct directory in one step.

๐ŸŽฏ Purpose & Impact

  • ๐Ÿ› ๏ธ Simplifies the workflow: The new approach reduces unnecessary steps in the installation process, leading to cleaner and more efficient code.
  • โšก Improves automation efficiency: Faster installation enhances workflow execution speed, benefiting developers running the checks.
  • ๐ŸŒฑ Maintenance-friendly: A streamlined script is easier to maintain and less prone to errors, improving long-term reliability.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Dec 25, 2024
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant
Copy link
Member

๐Ÿ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/hub ๐Ÿš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • โœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and reference any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • โœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/hub main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • โœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • โœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • โœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • โœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement (CLA) if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • โœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." โ€” Bruce Lee

For additional context, please refer to our projectโ€™s contributing guidelines. Donโ€™t hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! ๐Ÿš€

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 058e2da into main Dec 25, 2024
3 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch December 25, 2024 19:44
@UltralyticsAssistant
Copy link
Member

๐ŸŽ‰ Woohoo! PR merged! Huge thanks to @glenn-jocher for making our workflows more efficient and elegant with this update. ๐Ÿš€ Your streamlined solution not only saves time but also makes the process cleaner and more robustโ€”truly a win for everyone! ๐Ÿ™Œ

As Leonardo da Vinci once said, "Simplicity is the ultimate sophistication." Your contribution exemplifies that beautifully. Thanks for helping us move towards smarter and smoother automationโ€”you're making a lasting impact! ๐ŸŒŸ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants