Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert --save-txt to default False #10213

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Revert --save-txt to default False #10213

merged 2 commits into from
Nov 18, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 18, 2022

Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated argument behavior and documentation for classification predictions.

πŸ“Š Key Changes

  • Changed the default action for the --save-txt argument from store_false to store_true in classify/predict.py.
  • Removed a line in the classify/tutorial.ipynb notebook that indicated text label results were saved, to reflect the new default behavior.

🎯 Purpose & Impact

  • The updated --save-txt argument makes it easier for users to save text results by default, improving the out-of-the-box experience.
  • The tutorial update helps prevent confusion, ensuring that the documentation matches the actual behavior of the code.
  • Potential impact includes users automatically receiving text files with results, which could be beneficial for record-keeping or further analysis without needing additional command line arguments. πŸ“ˆ

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher self-assigned this Nov 18, 2022
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 9bf1855 into master Nov 18, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-3 branch November 18, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant