-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --output and --save-conf options to test.py #1182
Adding --output and --save-conf options to test.py #1182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @olehb, thank you for submitting a PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- Verify your PR is up-to-date with origin/master. If your PR is behind origin/master update by running the following, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
- Verify all Continuous Integration (CI) checks are passing.
- Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
@olehb and all, I've updated this very good PR with some updated directory handling for test.py outputs. All test.py outputs will now be placed by default in a new New runs of test.py will delete and reuse the same |
@olehb PR is now merged! Feel free to provide feedback on anything else you see that could use improvement. Thank you for your contributions. |
* Adding --output and --save-conf options to test.py * Update help fields * Update test.py * Make arguments and comments uniform with test.py * Remove previous and print save_dir on finish Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
* Adding --output and --save-conf options to test.py * Update help fields * Update test.py * Make arguments and comments uniform with test.py * Remove previous and print save_dir on finish Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
* Adding --output and --save-conf options to test.py * Update help fields * Update test.py * Make arguments and comments uniform with test.py * Remove previous and print save_dir on finish Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Cleaner PR to replace #1175
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Improvement of result saving in object detection and testing scripts.
π Key Changes
save_dir
variable unified across detection and test scripts.--save-conf
flag.π― Purpose & Impact