Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent check_git_status() in docker images #1951

Merged
merged 2 commits into from
Jan 16, 2021
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 16, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced git status checks to avoid unnecessary prompts in Docker environments.

πŸ“Š Key Changes

  • Added a condition to skip git status checks inside Docker containers.

🎯 Purpose & Impact

  • Purpose: The change aims to prevent git status warnings from appearing when the YOLOv5 code is being run inside a Docker container. This is because Docker containers are often used for isolated, consistent environments and the software is not expected to be updated within them.
  • Impact: Users running YOLOv5 in Docker will have a cleaner console output without irrelevant warnings, resulting in a more streamlined experience.
  • It's beneficial for deployment scenarios where the code is not meant to be updated regularly, reducing unnecessary clutter in the logs. πŸ³πŸ’‘

@glenn-jocher glenn-jocher changed the title prevent check_git_status() running docker images prevent check_git_status() in docker images Jan 16, 2021
@glenn-jocher glenn-jocher merged commit e8a41e8 into master Jan 16, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch January 16, 2021 09:15
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
* prevent check_git_status() running docker images

* Update general.py
taicaile pushed a commit to taicaile/yolov5 that referenced this pull request Oct 12, 2021
* prevent check_git_status() running docker images

* Update general.py
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* prevent check_git_status() running docker images

* Update general.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant