Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download() ThreadPool update #3027

Merged
merged 3 commits into from
May 4, 2021
Merged

download() ThreadPool update #3027

merged 3 commits into from
May 4, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 4, 2021

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved data processing and multi-threaded download in YOLOv5 Objects365 configuration.

πŸ“Š Key Changes

  • Updated the image count in the Objects365 training dataset config to an exact figure (1,742,289 images).
  • Modified the download script to retain downloaded files by setting delete=False.
  • Added functionality to move images into the correct directory after download.
  • Enhanced classes enumeration consistency during label processing by incrementing class index by 1.
  • Improved thread handling in multi-threaded downloads with thread pool close and join methods.

🎯 Purpose & Impact

  • The exact image count provides clarity on the dataset size.
  • Retaining downloads avoids re-downloading, saving time for users.
  • Automatically moving images streamlines dataset organization, simplifying setup for training.
  • Class index change ensures correct progress tracking and clear logging during data setup.
  • Thread pool enhancements lead to more reliable downloads, preventing potential issues with unfinished threads.

Overall, these changes are set to enhance user experience with more efficient data handling and accurate progress tracking. This can be particularly beneficial for users training YOLOv5 on the Objects365 dataset, as it may lead to a smoother and more transparent training preparation phase. πŸš€πŸ”„

@glenn-jocher glenn-jocher merged commit 8cab907 into master May 4, 2021
@glenn-jocher glenn-jocher deleted the o3 branch May 4, 2021 21:37
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
* download() ThreadPool update

* update train image count

* cid + 1
danny-schwartz7 pushed a commit to danny-schwartz7/yolov5 that referenced this pull request May 22, 2021
* download() ThreadPool update

* update train image count

* cid + 1
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
* download() ThreadPool update

* update train image count

* cid + 1

(cherry picked from commit 8cab907)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* download() ThreadPool update

* update train image count

* cid + 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant