Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename class autoShape -> AutoShape #3173

Merged
merged 3 commits into from
May 16, 2021

Conversation

developer0hye
Copy link
Contributor

@developer0hye developer0hye commented May 15, 2021

follow other classes' naming convention

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved naming convention in YOLOv5 codebase.

πŸ“Š Key Changes

  • Renamed autoShape class to AutoShape for consistency in class naming.
  • Updated constructor and relevant print statements from autoShape to AutoShape.

🎯 Purpose & Impact

  • πŸ’… Code Readability: Harmonizes class naming conventions for better clarity, adhering to Python's CapWords convention.
  • πŸ› οΈ Refactoring: Reflects best practices in software development, but no changes in functionality.
  • πŸ” User Transparency: Clearer logging messages to inform users when AutoShape is enabled.

follow other class naming convention
follow other classes' naming convention
@glenn-jocher
Copy link
Member

@developer0hye thanks for the PR! This is not a bad idea to stay consistent with the pytorch camelcase module convention. It looks like there are 6 case-sensitive occurences of 'autoShape' in the repo, but the PR only includes 4 changes. Can you do the other two also please? Thanks!

Screenshot 2021-05-16 at 15 28 23

@developer0hye
Copy link
Contributor Author

@glenn-jocher I modified them! Please check my commit~

@glenn-jocher
Copy link
Member

@developer0hye looks good! Thank you for your contributions!

@glenn-jocher glenn-jocher merged commit be86c21 into ultralytics:master May 16, 2021
@developer0hye developer0hye deleted the patch-4 branch May 16, 2021 13:48
@developer0hye
Copy link
Contributor Author

developer0hye commented May 26, 2021

@glenn-jocher

Hello, jocher.

I measured the execution time of 300 over imagenet pretrained backbone networks.

Refer to https://github.com/developer0hye/pytorch-backbone-benchmark

I hope it helps you to find more efficient backbone than current yolov5's backbone model!

image

@glenn-jocher
Copy link
Member

@developer0hye wow, that's impressive!

You should definitely plot your results a few different ways, maybe using plotly or an interactive dashboard so you can mouse over the best datapoints and get their model names etc.

top1 vs time
top1 vs params
params vs time

@developer0hye
Copy link
Contributor Author

developer0hye commented May 26, 2021

@glenn-jocher

https://colab.research.google.com/drive/1NmkUIcA9Vt8U2WLXgZeIrIuY3yFW3Byx#scrollTo=9NyYQqA_iwzn

Look at this!

@glenn-jocher
Copy link
Member

@developer0hye very nice!

Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
* rename class autoShape -> AutoShape

follow other class naming convention

* rename class autoShape -> AutoShape

follow other classes' naming convention

* rename class autoShape -> AutoShape

(cherry picked from commit be86c21)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* rename class autoShape -> AutoShape

follow other class naming convention

* rename class autoShape -> AutoShape

follow other classes' naming convention

* rename class autoShape -> AutoShape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants