-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename class autoShape -> AutoShape #3173
Conversation
follow other class naming convention
follow other classes' naming convention
@developer0hye thanks for the PR! This is not a bad idea to stay consistent with the pytorch camelcase module convention. It looks like there are 6 case-sensitive occurences of 'autoShape' in the repo, but the PR only includes 4 changes. Can you do the other two also please? Thanks! |
@glenn-jocher I modified them! Please check my commit~ |
@developer0hye looks good! Thank you for your contributions! |
Hello, jocher. I measured the execution time of 300 over imagenet pretrained backbone networks. Refer to https://github.com/developer0hye/pytorch-backbone-benchmark I hope it helps you to find more efficient backbone than current yolov5's backbone model! |
@developer0hye wow, that's impressive! You should definitely plot your results a few different ways, maybe using plotly or an interactive dashboard so you can mouse over the best datapoints and get their model names etc. top1 vs time |
@developer0hye very nice! |
* rename class autoShape -> AutoShape follow other class naming convention * rename class autoShape -> AutoShape follow other classes' naming convention * rename class autoShape -> AutoShape (cherry picked from commit be86c21)
* rename class autoShape -> AutoShape follow other class naming convention * rename class autoShape -> AutoShape follow other classes' naming convention * rename class autoShape -> AutoShape
follow other classes' naming convention
π οΈ PR Summary
Made with β€οΈ by Ultralytics Actions
π Summary
Improved naming convention in YOLOv5 codebase.
π Key Changes
autoShape
class toAutoShape
for consistency in class naming.autoShape
toAutoShape
.π― Purpose & Impact