Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wandb_utils.py #4953

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Update wandb_utils.py #4953

merged 1 commit into from
Sep 28, 2021

Conversation

d57montes
Copy link
Contributor

@d57montes d57montes commented Sep 27, 2021

is_valset_wandb_artifact and is_trainset_wandb_artifact were referenced before assignment causing wandb to be unusable.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhancement of Weights & Biases integration for dataset tracking.

📊 Key Changes

  • Split a single flag is_wandb_artifact into two: is_trainset_wandb_artifact and is_valset_wandb_artifact.
  • Improved clarity in distinguishing between training and validation dataset artifact status within Weights & Biases.

🎯 Purpose & Impact

  • Provides better granularity by separately identifying the use of Weights & Biases artifacts for training and validation datasets.
  • 🎉 Allows users to more accurately track and version their datasets, potentially improving experiment management and reproducibility.
  • Minimal user impact in terms of usability, mostly affecting how data is logged and tracked in the backend.

`is_valset_wandb_artifact` and `is_trainset_wandb_artifact` were referenced before assignment causing wandb to be unusable.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @d57montes, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
  • ✅ Verify all Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher
Copy link
Member

@d57montes thanks for the PR!

@AyushExel can you review this?

@AyushExel
Copy link
Contributor

@d57montes Thanks for flagging this. I think line is_wandb_artifact = False can be removed too. Please verify.
@glenn-jocher Yes, this looks good :)

@AyushExel
Copy link
Contributor

@glenn-jocher approved the changes

@glenn-jocher
Copy link
Member

@AyushExel thanks for the review! Yes is_wandb_artifact = False is removed in this PR as you suggested.

@glenn-jocher glenn-jocher merged commit 0c87478 into ultralytics:master Sep 28, 2021
@glenn-jocher
Copy link
Member

@d57montes @AyushExel PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐

CesarBazanAV pushed a commit to CesarBazanAV/yolov5 that referenced this pull request Sep 29, 2021
`is_valset_wandb_artifact` and `is_trainset_wandb_artifact` were referenced before assignment causing wandb to be unusable.
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
`is_valset_wandb_artifact` and `is_trainset_wandb_artifact` were referenced before assignment causing wandb to be unusable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants