Allow list for Comet artifact class 'names' field #9654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Comet logger, when I run train.py, it wants to download the data artifact. It was requiring me to format the 'names' field in the data artifact metadata as a dictionary, so I've changed this so that it also accepts a list. Signed-off-by: KristenKehrer <34010022+KristenKehrer@users.noreply.github.com>
for more information, see https://pre-commit.ci
DN6
reviewed
Sep 30, 2022
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> Signed-off-by: KristenKehrer <34010022+KristenKehrer@users.noreply.github.com>
|
@KristenKehrer @DN6 PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Comet logger, when I run train.py, it wants to download the data artifact. It was requiring me to format the 'names' field in the data artifact metadata as a dictionary, so I've changed this so that it also accepts a list.
Signed-off-by: KristenKehrer 34010022+KristenKehrer@users.noreply.github.com
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced dataset artifact
nameshandling in Comet Logger for YOLOv5.📊 Key Changes
namesfield as both dictionary and list in dataset metadata.namesfield is in an invalid format.🎯 Purpose & Impact
namesto be defined as either a list or a dictionary, making it easier to work with various dataset formats.namesformat increases reliability, ensuring users are aware of configuration issues promptly.