Support offset arg in pluralTypeHandler #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2021
ultraq
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
This was the first I had ever learned of the offset syntax, and it's kinda confusing! 😵 While reading about it, I found that there's even a linting rule out there to prevent the use of it because it's complicated! 😆 https://formatjs.io/docs/tooling/linter/#no-offset
|
And 0.10.1 has been published with this change in it 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests and support for the plural type handler's offset arg. This arg is widely supported in other message formatting libraries, and isn't particularly difficult to implement now that #8 has been merged