random: Replace system random calls with STL #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. This looks like a good change. I asked @tampsa to review this when he has time. We will test windows and give feedback if changes are needed. Thanks! BR, Joni Räsänen |
|
Hi, Thanks for the pull request, it looks good. We tested it and will merge it. -Heikki Tampio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a deadlock when generate() was calling
syscall(SYS_getrandom, buf, n, 0)on an embedded system. I went with a standard solution, which cut down on some code and should be more portable. I also removed the apparently unusedgenerate_64()function. If that function is truly needed, I can update to include it.Tested with gcc on linux, unable to test on windows.