Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert to an Analyzer #22

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat: convert to an Analyzer #22

merged 3 commits into from
Dec 16, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 11, 2024

To ease the integration inside golangci-lint, I converted the Run function into an Analyzer.

@martialblog
Copy link
Contributor

@ldez Really admiring all the work you put into golangci!

@robinknaapen
Copy link
Contributor

robinknaapen commented Dec 11, 2024

@ldez thanks for the contribution. We appreciate the effort 🙏

Currently we are in a busy state, since the holidays are around the corner.

I will review this PR and ask a peer to double check it.

That said, this will likely happen next week.

Thanks for being patient.

Best regards and happy holidays (you too @martialblog).

@robinknaapen
Copy link
Contributor

@ldez

LGTM, I've asked a co-worker for a second review

Copy link

@elwint elwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elwint elwint merged commit 955cef7 into ultraware:master Dec 16, 2024
3 checks passed
@robinknaapen
Copy link
Contributor

@ldez

Thanks for the contribution.

Do you intend to create a PR on golangci-lint, or are we expected to do so?

Kind regards

@ldez
Copy link
Contributor Author

ldez commented Dec 16, 2024

Thank you for merging the PR, I handle the update inside golangci-lint.

@ldez ldez deleted the feat/analyzer branch December 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants