-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert to an Analyzer #22
Conversation
@ldez Really admiring all the work you put into golangci! |
@ldez thanks for the contribution. We appreciate the effort 🙏 Currently we are in a busy state, since the holidays are around the corner. I will review this PR and ask a peer to double check it. That said, this will likely happen next week. Thanks for being patient. Best regards and happy holidays (you too @martialblog). |
LGTM, I've asked a co-worker for a second review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the contribution. Do you intend to create a PR on golangci-lint, or are we expected to do so? Kind regards |
Thank you for merging the PR, I handle the update inside golangci-lint. |
To ease the integration inside golangci-lint, I converted the
Run
function into an Analyzer.