Merge pull request upbound#180 from sergenyalcin/fix-skip-update

Fix skip update mechanism
ulucinar · Feb 26, 2024 · 2eb3bf5 · 2eb3bf5
2 parents ac36a0c + 87db4d7
commit 2eb3bf5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/internal/tester.go b/internal/tester.go
@@ -139,8 +139,6 @@ func (t *tester) prepareConfig() (*config.TestCase, []config.Resource, error) {
 				return nil, nil, errors.Wrapf(err, "cannot unmarshal JSON object: %s", updateParameter)
 			}
 			example.UpdateAssertKey, example.UpdateAssertValue = convertToJSONPath(data, "")
-		} else {
-			tc.SkipUpdate = true
 		}
 		disableImport, ok := annotations[config.AnnotationKeyDisableImport]
 		if ok && disableImport == "true" {
@@ -152,8 +150,10 @@ func (t *tester) prepareConfig() (*config.TestCase, []config.Resource, error) {
 				if disableImport == "true" {
 					tc.SkipImport = true
 				}
+				if updateParameter == "" {
+					tc.SkipUpdate = true
+				}
 				example.Root = true
-
 			}
 		}