Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to Svelte 5 and update Lexical dependency to 0.20 #101

Closed
wants to merge 9 commits into from
Closed

migrate to Svelte 5 and update Lexical dependency to 0.20 #101

wants to merge 9 commits into from

Conversation

fokx
Copy link
Contributor

@fokx fokx commented Nov 26, 2024

This PR contains various commits:

  • update lexical related dependencies to latest version(0.20)
  • migrate to Svelte 5 using pnpx sv migrate svelte-5 and manually fix some errors

fokx added 8 commits November 26, 2024 19:05
@fokx
update lexical to 0.20.0
b2ac1be
@fokx
migrate packages/svelte-lexical: pnpx sv migrate svelte-5; pnpm update
e3fc08b
@fokx
enable preprocessing script tags (vitePreprocess({ script: true })…
ec21afc 
…) to fix error of enum in typescript:

 src/lib/components/toolbar/FontSizeEntry.svelte:15:2 TypeScript language features like enums are not natively supported
@fokx
fix inputValue not $state() migration error in FontSizeEntry.svelte
4dec4de
@fokx
migrate demos/*: pnpx sv migrate svelte-5; pnpm update
e86c4ba
@fokx
fix migration error of SvelteComponent if deprecated
5a66985
@fokx
fix migration error: fix Cannot do bind:loggedCommands={undefined}`…
008b237 
… when `loggedCommands` has a fallback value`; fix `mode` used before defined error in InsertImageDialog.svelte
@fokx
Merge branch 'umaranis:master' into master
df1bd76
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-lexical ❌ Failed (Inspect) Nov 28, 2024 5:55am
svelte-lexical-playground ❌ Failed (Inspect) Nov 28, 2024 5:55am

@umaranis
Copy link
Owner

Thanks for the PR @fokx

Let me review and get back to you.

@umaranis
Copy link
Owner

About 8 tests are failing, mainly related to Images.

I get the following when trying to add an image.
image

@umaranis
Copy link
Owner

umaranis commented Nov 27, 2024 •
edited
Loading

Also, svelte-check finds 64 errors and 6 warnings in svelte-lexical package (there are also errors in other packages).

Upgrades to lexical 20 and svelte 5 are major changes and I would suggest to keep them separate.

@umaranis
Copy link
Owner

@fokx , I have upgraded to Svelte 5.
Thanks for your contribution. I have included you as co-author on the relevant commits.

@umaranis umaranis closed this Dec 24, 2024
@fokx
Copy link
Contributor Author

fokx commented Dec 24, 2024

Thank you sir. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fokx @umaranis