Expose eth_maxPriorityFeePerGas JSON RPC function
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Stefan-Ethernal
changed the title
eth_maxPriorityFeePerGaseth_maxPriorityFeePerGas JSON RPC function
Stefan-Ethernal
force-pushed
the
feat/expose-eip-1559-endpoints
branch
from
b504bcd
to
ff3c370
Compare
ferranbt
requested changes
Aug 8, 2023
jsonrpc/eth_test.go
Outdated
| @@ -401,3 +401,40 @@ func TestEthFeeHistory(t *testing.T) { | |||
| assert.NoError(t, err) | |||
| assert.NotNil(t, fee) | |||
| } | |||
|
|
|||
| func TestEthMaxPriorityFeePerGas(t *testing.T) { | |||
| s := testutil.DeployTestServer(t, nil) | |||
There was a problem hiding this comment.
Can you use s := testutil.NewTestServer(t) instead? I am trying not to deploy a new server for each unit test as it was done before. Otherwise, it taxes too much the CI.
There was a problem hiding this comment.
Fixed 2be2739
…rameter to the function
Stefan-Ethernal
force-pushed
the
feat/expose-eip-1559-endpoints
branch
from
3d60565
to
647d932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
eth_maxPriorityFeePerGasendpoint, which is introduced with EIP-1559. It also added a unit test that tests it. However, when such a unit test was introduced, it was realized that with the current implementation, it was impossible to send dynamic fee transactions, because of the following error returned from Geth:both gasPrice and (maxFeePerGas or maxPriorityFeePerGas) specified. That is why transaction marshaling and unmarshalling logic needed to be changed, sogasPriceis not included for dynamic fee transactions anymore.Also, rename the
eth_feeHistoryparameters to be aligned with the specification and also provide therewardPercentilesparameter (https://docs.alchemy.com/reference/eth-feehistory).