no need to redirect when removing tab. router handles this fine

umbraco · Dec 11, 2024 · 5f291ba · 5f291ba
1 parent eec7b01
commit 5f291ba
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/...c/packages/core/content-type/workspace/views/design/content-type-design-editor.element.ts b/...c/packages/core/content-type/workspace/views/design/content-type-design-editor.element.ts
@@ -269,9 +269,8 @@ export class UmbContentTypeDesignEditorElement extends UmbLitElement implements
 	#deleteTab(tabId?: string) {
 		if (!tabId) return;
 		this.#workspaceContext?.structure.removeContainer(null, tabId);
-		// TODO: We should only navigate away if it was the last tab and if it was the active one... [NL]
-		if (this.#tabsStructureHelper?.isOwnerChildContainer(tabId)) {
-			window.history.replaceState(null, '', this._routerPath + (this._routes[0]?.path ?? '/root'));
+		if (this._activeTabId === tabId) {
+			this._activeTabId = undefined;
 		}
 	}
 	async #addTab() {