Skip to content

Commit

Permalink
Track ng-repeat with id instead of label (#9340)
Browse files Browse the repository at this point in the history
(cherry picked from commit 39c4dcd)
  • Loading branch information
SteveVaneeckhout authored and nul800sebastiaan committed Nov 23, 2020
1 parent d4fa37d commit 7c20ade
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div>
<ng-form name="tabbedContentForm">
<div class="umb-group-panel" retrive-dom-element="registerPropertyGroup(element[0], attributes.appAnchor)" data-app-anchor="{{group.id}}" data-element="group-{{group.alias}}" ng-repeat="group in content.tabs track by group.label">
<div class="umb-group-panel" retrive-dom-element="registerPropertyGroup(element[0], attributes.appAnchor)" data-app-anchor="{{group.id}}" data-element="group-{{group.alias}}" ng-repeat="group in content.tabs track by group.id">

<div class="umb-group-panel__header">
<div id="group-{{group.id}}">{{ group.label }}</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<ng-form name="elementTypeContentForm">
<div class="umb-group-panel"
data-element="group-{{group.alias}}"
ng-repeat="group in vm.model.variants[0].tabs track by group.label">
ng-repeat="group in vm.model.variants[0].tabs track by group.id">

<div class="umb-group-panel__header">
<div id="group-{{group.id}}">{{ group.label }}</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="umb-package-details">
<div class="umb-package-details__main-content">

<umb-box data-element="node-info-membership" ng-repeat="group in node.tabs| filter: {properties:{view:'readonlyvalue'}} track by group.label">
<umb-box data-element="node-info-membership" ng-repeat="group in node.tabs| filter: {properties:{view:'readonlyvalue'}} track by group.id">

<div class="umb-group-panel__header">
<div>{{ group.label }}</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="form-horizontal" ng-controller="Umbraco.Editors.Media.Apps.ContentController as vm">
<div class="umb-group-panel" data-element="group-{{group.alias}}" ng-repeat="group in content.tabs | filter: { hide : '!' + true } track by group.label">
<div class="umb-group-panel" data-element="group-{{group.alias}}" ng-repeat="group in content.tabs | filter: { hide : '!' + true } track by group.id">

<div class="umb-group-panel__header">
<div>{{ group.label }}</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="form-horizontal" ng-controller="Umbraco.Editors.Member.Apps.ContentController as vm">

<div class="umb-group-panel" ng-repeat="group in content.tabs track by group.label">
<div class="umb-group-panel" ng-repeat="group in content.tabs track by group.id">

<div class="umb-group-panel__header">
<div>{{ group.label }}</div>
Expand Down

0 comments on commit 7c20ade

Please sign in to comment.