Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback UI doesn't work with only segment variants #10281

Closed
nielslyngsoe opened this issue May 18, 2021 · 3 comments
Closed

Rollback UI doesn't work with only segment variants #10281

nielslyngsoe opened this issue May 18, 2021 · 3 comments
Labels
status/stale Marked as stale due to inactivity

Comments

@nielslyngsoe
Copy link
Member

The rollback feature does not work with content that only has Segmented Variants.

image

@PerplexDaniel don't you need this in your setup?

@PerplexDaniel
Copy link
Contributor

@nielslyngsoe I'm afraid there might still be a couple things breaking with segments only just like #10274 that I noticed yesterday. I believe the rollback was a "known issue" at some point during our work on segments but I cannot recall the details.

This one may need the ability to select culture + segment (rather than just "Language") to rollback, or alternatively rename the "Language" to "Variant" and display all variants there (with there .displayName property).

So not sure if this is immediately up for grabs as perhaps HQ wants to decide what the UI should look like (culture + segment dropdowns, 1 dropdown, something else?)

@nielslyngsoe
Copy link
Member Author

I think any working solution would be welcome.

So the current experience shows both segmented and culture variants in the list of "languages"
image

But from our current approach on structuring variants, we see the Culture as the parent of a Segments. (If only segmented variants when just a dropdown of segments would be fine)
So providing that structure could be a potential help for users.

From a design point of view, the whole rollback experience is a bit lacking, as the variant dropdown should show the same information as the Variant-picker on Document-level:
image

But that's a bigger change.

I could also argue that it isn't needed to select the variant in the rollback, as you already are on a specific variant. Based on the editor's context.

In other words, the Rollback dialog should just display which variant it will affect(based on the current active variant) and instead concentrate on providing information about the rollback version. As this list is rather useless:
image

Well, that didn't give you a clear answer, but I hope it suits you to understand where we are at — any improvement is an improvement :-)

@umbrabot
Copy link

Hiya @nielslyngsoe,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@umbrabot umbrabot added the status/stale Marked as stale due to inactivity label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale Marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

3 participants