Variants dialog crashes when publishing (segment + no culture)

[PerplexDaniel]

Umbraco version

I am seeing this issue on Umbraco version: 8.13.0

Bug summary

If a page has multiple variants that are varied only by segment (not by culture), the save/publish/unpublish dialog will crash when the user tries to perform a Save/Publish/Unpublish action.

The dialog will not render any variants and the console shows an error, see images below.

This was caused by the changes of PR #9797 which improves the sorting of variants in the specified dialog, specially in the sortVariants and getSortedVariantsAndSegments functions.
These functions directly access variant.language.{culture,isDefault,isMandatory} but do not account for the case where variant.language is simply null. That happens when culture variation is not enabled. So this will crash every time when only segment variations are enabled and some segment variants are created.

So the fix for this is to account for language being null and handle accordingly. That is, something like
a.language.isDefault
should probably just be
a.language != null && a.language.isDefault

Language is NULL:

Steps to reproduce

• Add some variants to a node that have segmentation enabled but not culture.
  • Instructions are available in Better sorting of variants in variant picker and publishing dialogs #9797 at the "How and what to test:" section.
• Try to save/publish/unpublish one or more variants in Umbraco.

Expected result

The overlay shows all variants and they can be saved/published/unpublished without issues.

Actual result

The overlay is empty because the JavaScript crashes, we cannot save/publish/unpublish anything.

---

This item has been added to our backlog AB#11985

[nul800sebastiaan]

Thanks for the report @PerplexDaniel - we'll have a look at fixing that for 8.13.1! 👍

[nul800sebastiaan]

Fixed in #10284