Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10274 Variant sorting should take into account that there might not be any language (#10278) #10284

Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented May 18, 2021

When closing the Save & Publish dialog on variant content, we see an issue in the consol about infiniteEditors being undefined.

This PR fixes general potential issues with infiniteEditors not being present.

I've tested my known case, but it seems there is an extensive amount of testing needed to verify that the original PR works as it should, so please find inspiration here.

The original PR is here: #8522

Fixes #10274

nielslyngsoe and others added 2 commits May 18, 2021 11:08
…be any language (#10278)

* Variant sorting should take into account that there might not be any language available

* fix languages

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
@nul800sebastiaan nul800sebastiaan merged commit 017b56e into v8/contrib May 19, 2021
@nul800sebastiaan nul800sebastiaan deleted the v8/bugfix/8522-fix-infinite-editor-js-errors branch May 19, 2021 10:06
nul800sebastiaan pushed a commit that referenced this pull request May 19, 2021
…be any language (#10278) (#10284)

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
(cherry picked from commit 017b56e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variants dialog crashes when publishing (segment + no culture)
2 participants