Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Block level validation UI missing #16656

Closed
PerplexDaniel opened this issue Jun 25, 2024 · 2 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2200
Closed

[v14] Block level validation UI missing #16656

PerplexDaniel opened this issue Jun 25, 2024 · 2 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2200

Comments

@PerplexDaniel
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

Bug summary

In Block List / Block Grid there is no block level validation UI. If any of the blocks are invalid only the parent property itself (Block List / Block Grid) will be marked as invalid but you have no idea which block is invalid so this is not very user friendly. In addition, required properties are not marked with an asterisk (*) like in the past, and when you open each block the field that is invalid is not marked at all so you still have no idea what is wrong.

image
image
image

We are currently looking into migrating our custom block editor (Perplex.ContentBlocks) to v14 and it seems there is actually code for block level validation. You can pass in a dataPath to <umb-property-type-based-property> which seems to work somewhat although the error message does not work properly and just shows #validation_invalidEmpty.

image

Specifics

No response

Steps to reproduce

  1. Create an Element Type with at least 1 mandatory property
  2. Create a Block List datatype that uses the element type from step 1
  3. Add this Block List as a property on one of your regular doctypes
  4. Create some blocks without entering any data
  5. Save and Publish
  6. Observe a result similar to this:

image

When opening a block the invalid properties are not marked either so you really have no idea how to fix it and what to fix.

Expected result / actual result

No response

Copy link

Hi there @PerplexDaniel!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link

Thanks, @PerplexDaniel for reporting this issue. We are working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants