Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Validation System #2200

Merged
merged 99 commits into from
Aug 19, 2024
Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Aug 9, 2024

Finishing of the Validation System

This includes the features mentioned in the Readme below and a few implementations to prove the solution.

Note

Read src/packages/core/validation/README.md for more information on the system.

Implementations for:

  • Document Workspace
  • Block Workspace
  • Property Type Workspace (Property Setting Modal on Content Type)

Some partial implementations for:

  • Document Type Workspace
  • Data Type Workspace

Features not included:

  • Validation Invalid Badges on Workspace Views
  • Validation Invalid Badges on Tabs Navigation
  • Reset Validation when closing Block Workspace
  • Translations for validation messages

Fixes umbraco/Umbraco-CMS#16168
Fixes umbraco/Umbraco-CMS#16686
Fixes umbraco/Umbraco-CMS#16380
Fixes umbraco/Umbraco-CMS#16656
Fixes umbraco/Umbraco-CMS#16440
Fixes umbraco/Umbraco-CMS#16376
Fixes umbraco/Umbraco-CMS#16826

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review August 14, 2024 19:32
…idation' into v14/feature/document-validation-take1

# Conflicts:
#	src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts
#	src/packages/block/block-grid/context/block-grid-manager.context.ts
#	src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts
@nielslyngsoe nielslyngsoe changed the title Document Validation Feature: Document Validation Aug 15, 2024
@nielslyngsoe nielslyngsoe changed the title Feature: Document Validation Feature: Validation System Aug 16, 2024
@madsrasmussen madsrasmussen self-assigned this Aug 19, 2024
Copy link

sonarcloud bot commented Aug 19, 2024

@nielslyngsoe nielslyngsoe merged commit 3cefb9c into main Aug 19, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/document-validation-take1 branch August 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment