V10: Fix build warnings in core

src/Umbraco.Core/Actions/ActionAssignDomain.cs

@@ -9,25 +9,25 @@ namespace Umbraco.Cms.Core.Actions;
 public class ActionAssignDomain : IAction
 {
     /// <summary>
-    /// The unique action letter
+    ///     The unique action letter
     /// </summary>
     public const char ActionLetter = 'I';
 
-    /// <inheritdoc/>
+    /// <inheritdoc />
     public char Letter => ActionLetter;
 
-    /// <inheritdoc/>
+    /// <inheritdoc />
     public string Alias => "assignDomain";
 
-    /// <inheritdoc/>
+    /// <inheritdoc />
     public string Category => Constants.Conventions.PermissionCategories.AdministrationCategory;
 
-    /// <inheritdoc/>
+    /// <inheritdoc />
     public string Icon => "home";
 
-    /// <inheritdoc/>
+    /// <inheritdoc />
     public bool ShowInNotifier => false;
 
-    /// <inheritdoc/>
+    /// <inheritdoc />
     public bool CanBePermissionAssigned => true;
 }

src/Umbraco.Core/Actions/ActionBrowse.cs

@@ -1,40 +1,41 @@
-// Copyright (c) Umbraco.
+// Copyright (c) Umbraco.
 // See LICENSE for more details.
 
-namespace Umbraco.Cms.Core.Actions
+namespace Umbraco.Cms.Core.Actions;
+
+/// <summary>
+///     This action is used as a security constraint that grants a user the ability to view nodes in a tree
+///     that has  permissions applied to it.
+/// </summary>
+/// <remarks>
+///     This action should not be invoked. It is used as the minimum required permission to view nodes in the content tree.
+///     By
+///     granting a user this permission, the user is able to see the node in the tree but not edit the document. This may
+///     be used by other trees
+///     that support permissions in the future.
+/// </remarks>
+public class ActionBrowse : IAction
 {
     /// <summary>
-    /// This action is used as a security constraint that grants a user the ability to view nodes in a tree
-    /// that has  permissions applied to it.
+    ///     The unique action letter
     /// </summary>
-    /// <remarks>
-    /// This action should not be invoked. It is used as the minimum required permission to view nodes in the content tree. By
-    /// granting a user this permission, the user is able to see the node in the tree but not edit the document. This may be used by other trees
-    /// that support permissions in the future.
-    /// </remarks>
-    public class ActionBrowse : IAction
-    {
-        /// <summary>
-        /// The unique action letter
-        /// </summary>
-        public const char ActionLetter = 'F';
-
-        /// <inheritdoc/>
-        public char Letter => ActionLetter;
-
-        /// <inheritdoc/>
-        public bool ShowInNotifier => false;
-
-        /// <inheritdoc/>
-        public bool CanBePermissionAssigned => true;
-
-        /// <inheritdoc/>
-        public string Icon => string.Empty;
-
-        /// <inheritdoc/>
-        public string Alias => "browse";
-
-        /// <inheritdoc/>
-        public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
-    }
+    public const char ActionLetter = 'F';
+
+    /// <inheritdoc />
+    public char Letter => ActionLetter;
+
+    /// <inheritdoc />
+    public bool ShowInNotifier => false;
+
+    /// <inheritdoc />
+    public bool CanBePermissionAssigned => true;
+
+    /// <inheritdoc />
+    public string Icon => string.Empty;
+
+    /// <inheritdoc />
+    public string Alias => "browse";
+
+    /// <inheritdoc />
+    public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
 }

src/Umbraco.Core/Actions/ActionCollection.cs

@@ -1,60 +1,56 @@
 // Copyright (c) Umbraco.
 // See LICENSE for more details.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Umbraco.Cms.Core.Composing;
 using Umbraco.Cms.Core.Models.Membership;
 using Umbraco.Extensions;
 
-namespace Umbraco.Cms.Core.Actions
+namespace Umbraco.Cms.Core.Actions;
+
+/// <summary>
+///     The collection of actions
+/// </summary>
+public class ActionCollection : BuilderCollectionBase<IAction>
 {
     /// <summary>
-    /// The collection of actions
+    ///     Initializes a new instance of the <see cref="ActionCollection" /> class.
     /// </summary>
-    public class ActionCollection : BuilderCollectionBase<IAction>
+    public ActionCollection(Func<IEnumerable<IAction>> items)
+        : base(items)
     {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ActionCollection"/> class.
-        /// </summary>
-        public ActionCollection(Func<IEnumerable<IAction>> items)
-            : base(items)
-        {
-        }
+    }
 
-        /// <summary>
-        /// Gets the action of the specified type.
-        /// </summary>
-        /// <typeparam name="T">The specified type to get</typeparam>
-        /// <returns>The action</returns>
-        public T? GetAction<T>()
-            where T : IAction => this.OfType<T>().FirstOrDefault();
+    /// <summary>
+    ///     Gets the action of the specified type.
+    /// </summary>
+    /// <typeparam name="T">The specified type to get</typeparam>
+    /// <returns>The action</returns>
+    public T? GetAction<T>()
+        where T : IAction => this.OfType<T>().FirstOrDefault();
 
-        /// <summary>
-        /// Gets the actions by the specified letters
-        /// </summary>
-        public IEnumerable<IAction> GetByLetters(IEnumerable<string> letters)
-        {
-            IAction[] actions = this.ToArray(); // no worry: internally, it's already an array
-            return letters
-                .Where(x => x.Length == 1)
-                .Select(x => actions.FirstOrDefault(y => y.Letter == x[0]))
-                .WhereNotNull()
-                .ToList();
-        }
+    /// <summary>
+    ///     Gets the actions by the specified letters
+    /// </summary>
+    public IEnumerable<IAction> GetByLetters(IEnumerable<string> letters)
+    {
+        IAction[] actions = this.ToArray(); // no worry: internally, it's already an array
+        return letters
+            .Where(x => x.Length == 1)
+            .Select(x => actions.FirstOrDefault(y => y.Letter == x[0]))
+            .WhereNotNull()
+            .ToList();
+    }
 
-        /// <summary>
-        /// Gets the actions from an EntityPermission
-        /// </summary>
-        public IReadOnlyList<IAction> FromEntityPermission(EntityPermission entityPermission)
-        {
-            IAction[] actions = this.ToArray(); // no worry: internally, it's already an array
-            return entityPermission.AssignedPermissions
-                .Where(x => x.Length == 1)
-                .SelectMany(x => actions.Where(y => y.Letter == x[0]))
-                .WhereNotNull()
-                .ToList();
-        }
+    /// <summary>
+    ///     Gets the actions from an EntityPermission
+    /// </summary>
+    public IReadOnlyList<IAction> FromEntityPermission(EntityPermission entityPermission)
+    {
+        IAction[] actions = this.ToArray(); // no worry: internally, it's already an array
+        return entityPermission.AssignedPermissions
+            .Where(x => x.Length == 1)
+            .SelectMany(x => actions.Where(y => y.Letter == x[0]))
+            .WhereNotNull()
+            .ToList();
     }
 }

src/Umbraco.Core/Actions/ActionCollectionBuilder.cs

@@ -1,35 +1,32 @@
-// Copyright (c) Umbraco.
+// Copyright (c) Umbraco.
 // See LICENSE for more details.
 
-using System;
-using System.Collections.Generic;
-using System.Linq;
 using Umbraco.Cms.Core.Composing;
 
-namespace Umbraco.Cms.Core.Actions
+namespace Umbraco.Cms.Core.Actions;
+
+/// <summary>
+///     The action collection builder
+/// </summary>
+public class ActionCollectionBuilder : LazyCollectionBuilderBase<ActionCollectionBuilder, ActionCollection, IAction>
 {
-    /// <summary>
-    /// The action collection builder
-    /// </summary>
-    public class ActionCollectionBuilder : LazyCollectionBuilderBase<ActionCollectionBuilder, ActionCollection, IAction>
+    /// <inheritdoc />
+    protected override ActionCollectionBuilder This => this;
+
+    /// <inheritdoc />
+    protected override IEnumerable<IAction> CreateItems(IServiceProvider factory)
     {
-        /// <inheritdoc/>
-        protected override ActionCollectionBuilder This => this;
+        var items = base.CreateItems(factory).ToList();
 
-        /// <inheritdoc/>
-        protected override IEnumerable<IAction> CreateItems(IServiceProvider factory)
+        // Validate the items, no actions should exist that do not either expose notifications or permissions
+        var invalidItems = items.Where(x => !x.CanBePermissionAssigned && !x.ShowInNotifier).ToList();
+        if (invalidItems.Count == 0)
         {
-            var items = base.CreateItems(factory).ToList();
-
-            // Validate the items, no actions should exist that do not either expose notifications or permissions
-            var invalidItems = items.Where(x => !x.CanBePermissionAssigned && !x.ShowInNotifier).ToList();
-            if (invalidItems.Count == 0)
-            {
-                return items;
-            }
-
-            var invalidActions = string.Join(", ", invalidItems.Select(x => "'" + x.Alias + "'"));
-            throw new InvalidOperationException($"Invalid actions {invalidActions}'. All {typeof(IAction)} implementations must be true for either {nameof(IAction.CanBePermissionAssigned)} or {nameof(IAction.ShowInNotifier)}.");
+            return items;
         }
+
+        var invalidActions = string.Join(", ", invalidItems.Select(x => "'" + x.Alias + "'"));
+        throw new InvalidOperationException(
+            $"Invalid actions {invalidActions}'. All {typeof(IAction)} implementations must be true for either {nameof(IAction.CanBePermissionAssigned)} or {nameof(IAction.ShowInNotifier)}.");
     }
 }

src/Umbraco.Core/Actions/ActionCopy.cs

@@ -1,34 +1,33 @@
-// Copyright (c) Umbraco.
+// Copyright (c) Umbraco.
 // See LICENSE for more details.
 
-namespace Umbraco.Cms.Core.Actions
+namespace Umbraco.Cms.Core.Actions;
+
+/// <summary>
+///     This action is invoked when copying a document, media, member
+/// </summary>
+public class ActionCopy : IAction
 {
     /// <summary>
-    /// This action is invoked when copying a document, media, member
+    ///     The unique action letter
     /// </summary>
-    public class ActionCopy : IAction
-    {
-        /// <summary>
-        /// The unique action letter
-        /// </summary>
-        public const char ActionLetter = 'O';
+    public const char ActionLetter = 'O';
 
-        /// <inheritdoc/>
-        public char Letter => ActionLetter;
+    /// <inheritdoc />
+    public char Letter => ActionLetter;
 
-        /// <inheritdoc/>
-        public string Alias => "copy";
+    /// <inheritdoc />
+    public string Alias => "copy";
 
-        /// <inheritdoc/>
-        public string Category => Constants.Conventions.PermissionCategories.StructureCategory;
+    /// <inheritdoc />
+    public string Category => Constants.Conventions.PermissionCategories.StructureCategory;
 
-        /// <inheritdoc/>
-        public string Icon => "documents";
+    /// <inheritdoc />
+    public string Icon => "documents";
 
-        /// <inheritdoc/>
-        public bool ShowInNotifier => true;
+    /// <inheritdoc />
+    public bool ShowInNotifier => true;
 
-        /// <inheritdoc/>
-        public bool CanBePermissionAssigned => true;
-    }
+    /// <inheritdoc />
+    public bool CanBePermissionAssigned => true;
 }

src/Umbraco.Core/Actions/ActionCreateBlueprintFromContent.cs

@@ -1,29 +1,28 @@
-// Copyright (c) Umbraco.
+// Copyright (c) Umbraco.
 // See LICENSE for more details.
 
-namespace Umbraco.Cms.Core.Actions
+namespace Umbraco.Cms.Core.Actions;
+
+/// <summary>
+///     This action is invoked when creating a blueprint from a content
+/// </summary>
+public class ActionCreateBlueprintFromContent : IAction
 {
-    /// <summary>
-    /// This action is invoked when creating a blueprint from a content
-    /// </summary>
-    public class ActionCreateBlueprintFromContent : IAction
-    {
-        /// <inheritdoc/>
-        public char Letter => 'ï';
+    /// <inheritdoc />
+    public char Letter => 'ï';
 
-        /// <inheritdoc/>
-        public bool ShowInNotifier => false;
+    /// <inheritdoc />
+    public bool ShowInNotifier => false;
 
-        /// <inheritdoc/>
-        public bool CanBePermissionAssigned => true;
+    /// <inheritdoc />
+    public bool CanBePermissionAssigned => true;
 
-        /// <inheritdoc/>
-        public string Icon => "blueprint";
+    /// <inheritdoc />
+    public string Icon => "blueprint";
 
-        /// <inheritdoc/>
-        public string Alias => "createblueprint";
+    /// <inheritdoc />
+    public string Alias => "createblueprint";
 
-        /// <inheritdoc/>
-        public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
-    }
+    /// <inheritdoc />
+    public string Category => Constants.Conventions.PermissionCategories.ContentCategory;
 }