Use System.Text.Json in ColorPickerValueConverter

[CyberReiter]

Prerequisites

• I have added steps to test this contribution in the description below

Description

Improving performance of the ColorPickerValueConverter by using System.Text.Json instead of Newtonsoft.Json

How to test

• On a content type create a property using the ColorPicker editor
• Call this property in a template and make sure the values are getting displayed correctly

Benchmark

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19044.2130 (21H2)
Intel Core i9-10885H CPU 2.40GHz, 1 CPU, 16 logical and 8 physical cores
.NET SDK=7.0.100-rc.2.22477.23
  [Host]     : .NET 6.0.10 (6.0.1022.47605), X64 RyuJIT
  DefaultJob : .NET 6.0.10 (6.0.1022.47605), X64 RyuJIT


| Method |     Mean |     Error |    StdDev |  Gen 0 | Allocated |
|------- |---------:|----------:|----------:|-------:|----------:|
|    New | 2.806 us | 0.0561 us | 0.0468 us | 0.0229 |     200 B |
|    Old | 4.856 us | 0.0960 us | 0.1682 us | 0.5341 |   4,496 B |

[github-actions]

Hi there @CyberReiter, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nul800sebastiaan]

Hi @CyberReiter - Sorry for the late response, we're working on our backlog at the moment.

I will close this one and the related Newtonsoft updates. There are subtle differences between Newtonsoft and System.Text.Json that will lead to unexpected output and breaking things.

We are planning to remover Newtonsoft completely from the solution in Umbraco 13: umbraco/Announcements#9

Thanks for the PR!