Add VersionAssemblyName to package manifest

[ronaldbarendse]

Prerequisites

• I have added steps to test this contribution in the description below

Description

Currently the version in the package.manifest needs to be manually set (and kept up to date!) if you want to have it shown on the installed packages overview in the back-office and included in the telemetry data.

In most cases the package.manifest is shipped alongside an assembly (DLL), which is already versioned and with the changes in this PR, you can leave the version empty (or remove it from the JSON) and set versionAssemblyName to your package assembly name to have it automatically populated with the assembly version.

This ensures more packages will report the (correct) version and makes it easier for package authors (one less step/thing not to forget). The default dotnet new umbracopackage template will also automatically set this new property. I've also fixed an issue where the installed package overview didn't show the package version if a package migration state is already present in the database.

---

To test: build/pack Umbraco from the repository root, install the newly created package template, create/pack a new Umbraco package project and add that to the Umbraco.Web.UI project using:

dotnet pack --configuration Release --output build.out
dotnet new install build.out\Umbraco.Templates.*.nupkg
dotnet new umbracopackage --name Umbraco.Community.UmbracoPackage --output build.out\Umbraco.Community.UmbracoPackage
dotnet pack build.out\Umbraco.Community.UmbracoPackage --configuration Release --output build.out -p:EnablePackageValidation=false
dotnet add src\Umbraco.Web.UI package Umbraco.Community.UmbracoPackage --source build.out --prerelease

Next up, build the Umbraco.Web.UI project and start the application. You'll see the version is populated (instead of Unknown):

---

After testing, you can clean up using:

dotnet clean src\Umbraco.Web.UI
dotnet remove src\Umbraco.Web.UI package Umbraco.Community.UmbracoPackage
dotnet new uninstall Umbraco.Templates

# Optionally, if you also want the NuGet packages removed from your local cache:
dotnet nuget locals --clear all

[ronaldbarendse]

I've ensured the listed installed packages that only have a package migration plan will now use the version from the assembly they're defined in. So adding the following class into the example project (created above):

using Umbraco.Cms.Core.Packaging;

public class UmbracoPackage2MigrationPlan : PackageMigrationPlan
{
    public UmbracoPackage2MigrationPlan()
        : base("Umbraco.Community.UmbracoPackage2")
    {
    }

    protected override void DefinePlan()
    {
    }
}

Will result in listing Umbraco.Community.UmbracoPackage2 with the same version:

[bergmania]

Looks good, but we need to add the default to the RCL template too

[ronaldbarendse]

Looks good, but we need to add the default to the RCL template too

I've merged the changes that added the new Umbraco Package RCL template, updated that package manifest as well and updated the base branch to target the v12 release 👍🏻

[bergmania]

Great @ronaldbarendse