Updated the IsoDateTimeConverter initialization in the JsonDateTimeFo…

[miguelcrpinto]

Prerequisites

• I have added steps to test this contribution in the description below

Fix for issue 14306

Description

Updated the IsoDateTimeConverter initialization in the JsonDateTimeFormatAttribute to set the Culture to InvariantCulture so that the custom DateTime format symbols ( date and time separators) are respected independent of the CurrentCulture being used.

This can be tested by setting the back office language to Danish ("da-DK") and inspecting the response of the Get By Id API (/umbraco/backoffice/umbracoapi/content/GetById?id={node id}). Previously any date time properties were being serialized having . as time separator (example: 13.25.00) and now are being serialized with the format defined in the JsonDateTimeFormatFilter ("yyyy-MM-dd HH:mm:ss")

[github-actions]

Hi there @miguelcrpinto, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

@miguelcrpinto Thanks so much for creating this PR to fix the issue when scheduled publishing in Danish.

I will look at this soon, and then we can get it merged in!

Best

Emma

[emmagarland]

Hi @miguelcrpinto

Just to let you know, I've tested and verified that your fix does resolve the scheduled publishing issue in Danish (and possibly some other unknown date culture scenarios, too). Great stuff! 👍

Due to the scope of the change, we're just discussing this with HQ to make sure there aren't other scenarios or impacts to consider for this change (since the attribute affects quite a few areas by the fact it is an attribute).

We'll get back to you ASAP about this!

Thanks,

Emma

[miguelcrpinto]

@emmagarland as far as I could see (via "find all references" in Visual Studio), this attribute was only used in the Content controller. This should not affect any other areas because this was producing the intended format for all the other backoffice languages. In any case, it's always a good idea to double check with HQ :)

[emmagarland]

Thanks @miguelcrpinto! And for the documentation on the issue #14306.

I am just speaking with HQ to find out if we can merge this in soon,

Best regards

Emma

[emmagarland]

Hi @miguelcrpinto, thanks so much for your pull request to fix the issue where scheduled publishing fails in Danish, #14306

It has now been successfully merged! 🙌

Thanks for your help with this one, it is a great fix.

Best wishes

Emma