Remove duplicate name attribute in 2FA login form

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

Description

• Remove duplicate name attribute in 2FA login form.
• Use vm instead as reference instead of cvm to be consistent with other views.
• Define vm as const instead of let as another value isn't assigned - only to it's properties.

[github-actions]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @bjarnef,

Thanks for your PR to update the 2FA login form!

One of the Core Collaborators team will review this as soon as possible,

All the best,

Emma

[emmagarland]

Hi @bjarnef

I've got the 2fa showing up on my user from setting up as per the docs, but to save me time, to show this "One last step" form in the back-office, what 2fa setup did you use please?

Thanks 🙂

Emma

[bjarnef]

Hi @emmagarland
I didn't really tested this with 2FA, but it isn't valid to have more than one name attribute.

I am pretty sure browsers in this case will use the first attribute and since authForm is referenced in the controller.

[emmagarland]

Thanks @bjarnef

I managed to trigger the 2fa screen when logging in anyway, and looks good 👍

It has now been successfully merged and targeted for v12.3.0! 🙌

Finally, we have marked this PR with the project/bellisima label so that we will remember to revisit this feature for Bellissima as well. You're welcome to have a look at creating an equivalent PR for the new backoffice v14 as well if relevant, but if not then it's a reminder for the HQ team to implement the same functionality before new backoffice gets released.

Best wishes

Emma