Fix button styling in block list & block grid overlay

[erikjanwestendorp]

Description

Update blockgrid.blockconfiguration.overlay.less & blocklist.blockconfiguration.overlay.less so that the text in the button is visible. Use variables for color in the buttons instead of hardcoded value.

Before:

After:

[github-actions]

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Thanks for this update @erikjanwestendorp !

Someone from the collabs team will have a look at it soon!

[bjarnef]

Actually I suggested this a long time ago, but it didn't seem HQ wanted the text to be visible, but more like a placeholder button: #8686

But I think it is kinda inconsistent eith other pickers - also that these have rounded corners, but not elsewhere in the UI.

[erikjanwestendorp]

@bjarnef Thanks for your comment and the reference to your PR! IMHO it's weird that the text is not visible indeed.. 🙈 I was already surprised that this had not been resolved before, but now I understand why. Let's see what happens now 😛.

[nielslyngsoe]

@bjarnef @erikjanwestendorp First and foremost thanks for sharing opinions. I just wanted to let you know that we changed the approach to this with UI Library. Meaning in v.14 this text would be visible. :-) So it's good to make this change now.

[georgebid]

Hey @erikjanwestendorp sorry for the delay on this one, but all looks good from my testing so I have gone ahead and merged this in. Thanks again for your PR! 😸