Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a couple of occurrences where scopes was auto-completed while modified db state #14947

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fixed a couple of occurrences where scopes was auto-completed while modified db state #14947

merged 2 commits into from
Oct 10, 2023

Conversation

bergmania
Copy link
Member

@bergmania bergmania commented Oct 9, 2023 •
edited by nul800sebastiaan
Loading

Description

We know auto completed scopes can hide real errors, so this PR removes auto completed scopes of a couple of methods actually modifying the state of the db.

See #12553 for related info.

Maybe this is the root course of #14195

Test

  • In theory everything touched should be tested manually 🙈
  • Especially the content clean up background task.

@Zeegaan
Copy link
Member

Zeegaan commented Oct 10, 2023

I've tested this with 1000+ content nodes and it appears to be holding up fine, it might need real-world testing before we can confirm it closes #14195 😁
Looks good to me though 👍

@Zeegaan Zeegaan merged commit 41f8f03 into v12/dev Oct 10, 2023
16 checks passed
@Zeegaan Zeegaan deleted the v12/bugfix/do-not-use-autocomplete-in-scopes-when-modified-db branch October 10, 2023 09:51
@bergmania bergmania mentioned this pull request Nov 14, 2023
Merged
bergmania added a commit that referenced this pull request Nov 15, 2023
@bergmania
Fixed a couple of occurrences where scopes was auto-completed while m…
04e59e9 
…odified db state (#14947)

* Fixed a couple of occurrences where scopes was auto-complated while actually modified the state of the database.

* Added temp ctor to fix boot issue

(cherry picked from commit 41f8f03)
@KevinJump KevinJump mentioned this pull request Dec 4, 2023
Closed
@nul800sebastiaan nul800sebastiaan mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeegaan Zeegaan Zeegaan left review comments

Assignees
No one assigned
Labels
release/10.8.0 release/12.3.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergmania @Zeegaan @nul800sebastiaan