Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BlockEditorDataConverter method to BlockListPropertyEditorBase … #14960

Merged
merged 4 commits into from
Nov 30, 2023

Added additional comments to code changes

56b77cb
Select commit
Loading
Failed to load commit list.
Merged

Added BlockEditorDataConverter method to BlockListPropertyEditorBase … #14960

Added additional comments to code changes
56b77cb
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Oct 12, 2023 in 39s

CodeScene PR Check

✅ Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

Annotations

Check notice on line 65 in src/Umbraco.Infrastructure/PropertyEditors/BlockListPropertyEditorBase.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

ℹ Getting worse: Constructor Over-Injection 

BlockListEditorPropertyValueEditor increases from 10 to 11 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
View more details on CodeScene Delta Analysis