Add config to limit concurrent logins #14967
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 4 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method UmbracoSignInManager.cs: HandleSignIn
✅ Improving Code Health:
- Overall Code Complexity BackOfficeSignInManager.cs
- Overall Code Complexity UmbracoSignInManager.cs
- Primitive Obsession UmbracoSignInManager.cs
- Overall Code Complexity MemberSignInManager.cs
Annotations
Check warning on line 375 in src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
❌ Getting worse: Complex Method
HandleSignIn increases in cyclomatic complexity from 10 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.43 to 4.32, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 48.84% to 41.18%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 62 in src/Umbraco.Web.Common/Security/UmbracoSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ New issue: Constructor Over-Injection
UmbracoSignInManager has 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 1 in src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.83 to 4.54, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 41 in src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ Getting worse: Constructor Over-Injection
BackOfficeSignInManager increases from 10 to 11 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 74 in src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ Getting worse: Constructor Over-Injection
BackOfficeSignInManager increases from 9 to 10 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 98 in src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ New issue: Constructor Over-Injection
BackOfficeSignInManager has 9 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 36 in src/Umbraco.Web.Common/Security/MemberSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ Getting worse: Constructor Over-Injection
MemberSignInManager increases from 9 to 10 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 65 in src/Umbraco.Web.Common/Security/MemberSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ Getting worse: Constructor Over-Injection
MemberSignInManager increases from 7 to 9 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 67 in src/Umbraco.Web.Common/Security/MemberSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
ℹ New issue: Constructor Over-Injection
MemberSignInManager has 7 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 1 in src/Umbraco.Web.Common/Security/MemberSignInManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v12/dev)
✅ No longer an issue: Overall Code Complexity
The mean cyclomatic complexity in this module is no longer above the threshold