Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13: Add config to limit concurrent logins #14989

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

elit0451
Copy link
Member

@elit0451 elit0451 commented Oct 17, 2023

Details

  • Cherry-picking commits from Add config to limit concurrent logins #14967;
  • Changing the default Umbraco:CMS:Security:AllowConcurrentLogins setting to false;
  • Removing the setting from Umbraco's dotnet new templates that was necessary for v12's PR.

Test

Check test steps in #14967.


⚠️ Breaking changes ⚠️ :
Changing the value of Umbraco:CMS:Security:AllowConcurrentLogins to false which prevents a user account from creating simultaneous sessions by default. Only 1 session is allowed to be active at a time.
This setting can always be set to true to not invalidate other active user sessions.

Remember❗ : https://docs.umbraco.com/umbraco-cms/reference/configuration/securitysettings article needs to be updated with the new default value for the 13.0.0 release.

bergmania and others added 2 commits October 17, 2023 10:28
* Add new config options

* Change validation interval + related changes

* Fix typo

* Temp fix

* Set new setting to false for new dotnet projects

* Added logic to update security stamp on sign in + fixed wierd code calling handle signIn twice

* Cleanup

* Adding empty ctors

---------

Co-authored-by: Elitsa <elm@umbraco.dk>
@Zeegaan
Copy link
Member

Zeegaan commented Oct 17, 2023

LGTM 🚀

@Zeegaan Zeegaan merged commit b0ca344 into v13/dev Oct 17, 2023
16 of 17 checks passed
@Zeegaan Zeegaan deleted the v13/feature/add-config-for-concurrent-logins-allowed branch October 17, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants