V13: Webhook all the things #15161
V13: Webhook all the things #15161
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 7 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Constructor Over-Injection ContentEmptiedRecycleBinWebhookEvent.cs: ContentEmptiedRecycleBinWebhookEvent
- Constructor Over-Injection ContentPublishedWebhookEvent.cs: ContentPublishedWebhookEvent
- Constructor Over-Injection ContentRolledBack.cs: ContentRolledBackWebhookEvent
- Constructor Over-Injection ContentSavedWebhookEvent.cs: ContentSavedWebhookEvent
- Complex Method ContentSortedWebhookEvent.cs: ConvertNotificationToRequestPayload
- Constructor Over-Injection ContentSortedWebhookEvent.cs: ContentSortedWebhookEvent
- Constructor Over-Injection MediaSavedWebhookEvent.cs: MediaSavedWebhookEvent
Annotations
Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Media/MediaSavedWebhookEvent.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
MediaSavedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentPublishedWebhookEvent.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
ContentPublishedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
ContentEmptiedRecycleBinWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentRolledBack.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
ContentRolledBackWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentSavedWebhookEvent.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
ContentSavedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 52 in src/Umbraco.Core/Webhooks/Events/Content/ContentSortedWebhookEvent.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Complex Method
ConvertNotificationToRequestPayload has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 34 in src/Umbraco.Core/Webhooks/Events/Content/ContentSortedWebhookEvent.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
ContentSortedWebhookEvent has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.