Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change format in convertToLocalMomentTime #15223

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Nov 16, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #15202

Description

In #13500 it adjusted a few functions to allow specifying a known parsing format instead of just default parsing format YYYY-MM-DD HH:mm:ss.

However it also passed in format to convertToLocalMomentTime() here: https://github.com/umbraco/Umbraco-CMS/pull/13500/files#diff-277b13396c90722385a98d599dbfea84855ff088949d00d4b5d14259208ed034R111

which before always used YYYY-MM-DDTHH:mm:ss format. Now it passed in format from where getLocalDate() is called, e.g. LLL or MMM Do YYYY, HH:mm.
https://github.com/search?q=repo%3Aumbraco%2FUmbraco-CMS%20getLocalDate&type=code

Copy link

github-actions bot commented Nov 16, 2023

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@andr317c
Copy link
Contributor

LGTM! 🚀

@andr317c andr317c merged commit 963e577 into umbraco:contrib Nov 16, 2023
14 of 15 checks passed
@bjarnef bjarnef deleted the patch-7 branch November 16, 2023 09:57
bergmania pushed a commit that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduling displays "Invalid date" in Umbraco 12.3.1
5 participants