Update LogDto.cs

[marwaldv]

fix: issue resolved, where content saving breaks due to saving to umbracoLog with error message like that: String or binary data would be truncated in table 'dto.umbracoLog', column 'parameters'. Truncated value: 'English (United States), German (Switzerland), French (France), Italian (Italy), Arabic (Iraq), Pers'...

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

[github-actions]

Hi there @marwaldv, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Hi @marwaldv ,

Thanks for your contribution. Someone from the core collaborators team will have a look at it soon.

May I already ask if there is an existing issue in the Issue tracker about this - and then add the number to your description for further reference-, or is this a problem you experienced and solved directly?

Thanks!

[marwaldv]

Hi @marwaldv ,

Thanks for your contribution. Someone from the core collaborators team will have a look at it soon.

May I already ask if there is an existing issue in the Issue tracker about this - and then add the number to your description for further reference-, or is this a problem you experienced and solved directly?

Thanks!

Hi @mikecp,

No, unfortunately I didn't find an existing issue for that in the current Umbraco version. But I've found an old issue from 2020 which was describing the same situation in Umbraco 8 (#9458) but was later closed and not resolved as it seems. I experienced the same issue now and solved it directly without opening an issue again for this.

Thanks for having a look on this topic.

[mikecp]

Hello @marwaldv ,

Sorry for the delayed feedback...

I had a look at your change, I have the impression that your solution will work when running Umbraco from scratch on an empty database, but I think this will give an error on an existing one. Your update should go together with a database migration to update the column size in existing databases. You can find examples of migrations in the namespace Umbraco.Cms.Infrastructure.Migrations.Upgrade
You will also need to integrate your migration in the UmbracoPlans.cs file in that same namespace.

Let me know if I can be of any further assistance with this and I'll gladly check what I can do 😉

Cheers!

[Matthew-Wise]

@marwaldv thanks for you PR sorry its taken a while to get merged, we have discussed with the CMS team and are happy for this change to only apply to newer installs

Thanks
Matt