Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved punctuation and sentence structure for better readability. #15279

Merged

Conversation

Programeerik
Copy link
Contributor

@Programeerik Programeerik commented Nov 21, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

I've improved punctuation and sentence structure for better readability.

The sentence before fix
BeforeFix

The sentence after fix
AfterFix

To test: Run the solution, start the tour of getting started and the sentence is now more clear and correct.

Copy link

github-actions bot commented Nov 21, 2023

Hi there @Programeerik, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Nov 22, 2023

Hi @Programeerik ,

Thank you for this update 👍 It makes the text more readable indeed. May I maybe ask an extra change: to be coherent with the rest of the written text (e.g. last sentence), I would also replace "you'll need" by "you will need". What do you think?

Cheers!

@mikecp mikecp self-assigned this Nov 22, 2023
@Programeerik
Copy link
Contributor Author

Your idea is indeed more coherent. I'll commit the new text.

@mikecp
Copy link
Contributor

mikecp commented Nov 22, 2023

Thanks @Programeerik for the quick update!

I think we're ready to merge then 😁
I see this is your first contribution to the Umbraco-CMS, congratulations 🎉
If you send us your user name on our.umbraco.com, @nul800sebastiaan will surely be happy to assign our shiny contributor's badge to you 🥇

And now we'll be looking forward to your next PR's 😉

Cheers!

@mikecp mikecp merged commit d34be8c into umbraco:contrib Nov 22, 2023
3 of 6 checks passed
@Programeerik
Copy link
Contributor Author

@mikecp Thanks! 🎉 I've created an account at our.umbraco.com and linked my Github account.
https://our.umbraco.com/members/Programeerik/
Is this enough information for @nul800sebastiaan or do I need to message him?

@mikecp
Copy link
Contributor

mikecp commented Nov 22, 2023

That's perfect @Programeerik 👍
You might need to wait a little because I know he's been quite busy lately. Oh, let me ping my teammate @busrasengul who can also do this I think 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants