Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V13: Login page backwards compatibility #15285

Merged
merged 10 commits into from
Nov 23, 2023
Merged

V13: Login page backwards compatibility #15285

merged 10 commits into from
Nov 23, 2023

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Nov 22, 2023 •
edited
Loading

Description

This PR aims to add a bit of backward compatibility with the V12 login screen in the following areas:

  • We are now loading the package bundle CSS on the login screen to allow to override CSS custom properties
  • We have added more variables that are overridable to allow to change the background and SVG graphics
  • The section is now present on the login screen as well as the backoffice
  • The debugger is now once again present on the login screen
  • Added a few missing meta tags that were present on the V12 login screen
  • The customizable greeting variables are back but have been reset to a variant of the word "Welcome" for all languages, but it allows previous user translations to take effect
  • Fixed a couple of language keys that were used incorrectly

@iOvergaard iOvergaard requested a review from JesmoDev November 22, 2023 13:29
@iOvergaard
Copy link
Contributor Author

@warrenbuckley We agreed that I would ping you once this PR was created 😇

JesmoDev
JesmoDev approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit 3b51805 into v13/dev Nov 23, 2023
16 checks passed
@iOvergaard iOvergaard deleted the v13/feature/login-customisation branch November 23, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesmoDev JesmoDev JesmoDev approved these changes

Assignees
No one assigned
Labels
category/front-end type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iOvergaard @JesmoDev